feat(IN-181): 시청자 분포 영역 제작#99
Merged
Merged
Conversation
|
@juuhye is attempting to deploy a commit to the kimyunhyeong's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
코드 확인했습니다. IN-180이후 작업분이 반영된 상태에서 개발하신 것 같아 IN-181관련 코드만 확인했습니다. 재사용 컴포넌트로 인해 이전 작업이 선행되어야 한다면, 컴포넌트 단위(롱폼/숏폼 평균 참여율 영역, 시청자 분포 영역 등)로 작업 범위를 나누는 방법도 좋지만, 페이지 내에서 공통으로 사용되는 요소(차트 등)를 먼저 개발한 뒤 이를 기반으로 작업을 진행해주시면 더욱 좋을 것 같습니다. 그렇게 해주시면 이전 브랜치가 반영되지 않은 상태에서도 파일을 분리해서 검토하는 번거로움 없이 리뷰를 진행할 수 있어, 리뷰 효율이 크게 높아질 것 같습니다. |
Collaborator
Author
|
네넵! 제가 이전 작업을 할때 브랜치 분리에 대해 이해가 잘 안되었던 거 같습니다 |
src/entities/channel/subscriberDistribution/ui/DistributionChart.tsx -> 연령, 국가별 막대차트 영역 src/entities/channel/subscriberDistribution/ui/GenderChart.tsx -> 성별 파이 차트 src/entities/channel/subscriberDistribution/ui/SubscriberChart.tsx -> 기존/ 신규 구독자 파이 차트 src/features/channel/contentType/ui/ContentType.tsx -> 기존 숏/롱 filter -> 범용 사용으로 수정 src/features/channel/subscriberDistribution/api/DistributionChartApi.ts src/features/channel/subscriberDistribution/api/subscriberChartApi.ts src/features/channel/subscriberDistribution/model/useDistributionChart.ts src/features/channel/subscriberDistribution/model/useSubscriberChart.ts -> api, React Query src/shared/ui/chart/barChart/BaseBarChart.tsx -> bar 차트 공통 UI
shunn2
reviewed
May 9, 2026
| @@ -0,0 +1,30 @@ | |||
| import { http, HttpResponse } from 'msw' | |||
| import { mockSubscriberDistribution } from '@/entities/channel/subscriberDistribution/mock/mockSubscriberDistribution' | |||
Collaborator
There was a problem hiding this comment.
mock에 index로 export 하고 있어서 경로 수정하면 좋을 것 같아요
| @@ -0,0 +1,15 @@ | |||
| import { http, HttpResponse } from 'msw' | |||
| import { mockSubscriber } from '@/entities/channel/subscriberDistribution/mock/mockSubscriberDistribution' | |||
| {data.map((item, idx) => ( | ||
| <div | ||
| className='flex h-24 items-center justify-end text-noto-body-xs-normal text-text-and-icon-default' | ||
| key={idx}> |
Collaborator
Author
There was a problem hiding this comment.
위에 작성해주신 모든 수정 사항 반영하였습니다! 감사합니다
oy-sghooncho
approved these changes
May 11, 2026
kimYunHyeong
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 개요
🗂 작업 유형
✏️ 작업 내용
src/entities/channel/subscriberDistribution/ui/DistributionChart.tsx -> 연령, 국가별 막대차트 영역
src/entities/channel/subscriberDistribution/ui/GenderChart.tsx -> 성별 파이 차트
src/entities/channel/subscriberDistribution/ui/SubscriberChart.tsx -> 기존/ 신규 구독자 파이 차트
src/features/channel/contentType/ui/ContentType.tsx -> 기존 숏/롱 filter -> 범용 사용으로 수정
src/features/channel/subscriberDistribution/api/DistributionChartApi.ts
src/features/channel/subscriberDistribution/api/subscriberChartApi.ts
src/features/channel/subscriberDistribution/model/useDistributionChart.ts
src/features/channel/subscriberDistribution/model/useSubscriberChart.ts -> api, React Query
src/shared/ui/chart/barChart/BaseBarChart.tsx -> bar 차트 공통 UI
✅ 셀프 체크리스트
💬 리뷰어에게